Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / vmdriver

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 2
  • Merge Requests 0
  • Wiki
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge request !6 opened 10 years ago by Guba Sándor@gubasandor 
  • Report abuse
Report abuse

Issue 365

Request to merge issue-365 into master

Merged by

The changes were merged into master

The source branch has been removed

  • Discussion 2
  • Commits 3
  • Changes
0/0 discussions resolved
  • Őry Máté
    @orymate started a discussion on an old version of the diff 10 years ago
    vmdriver.py
    563 566 disk = VMDisk.deserialize(disk)
    564 567 domain.detachDevice(disk.dump_xml())
    568 # Libvirt does NOT report failed detach so test it.
    569 __check_detach(domain, disk.source)
    570
    571
    572 def __check_detach(domain, disk):
    573 """ Test if detach was successfull by searching
    574 for disk in the XML"""
    575 xml = domain.XMLDesc()
    576 root = ET.fromstring(xml)
    577 devices = root.find('devices')
    578 for d in devices.findall("disk"):
    579 if disk in d.find('source').attrib.values()[0]:
    580 raise Exception("Disk could not been detached. "
    581 "Check if acpiphp module is loaded.")
    • Őry Máté @orymate commented 10 years ago
      Owner

      Check if hot plug support is enabled (acpiphp module on Linux)

      Check if hot plug support is enabled (acpiphp module on Linux)
    Please register or sign in to reply
  • Őry Máté @orymate commented 10 years ago
    Owner

    +1

    +1
  • Guba Sándor @gubasandor Added 1 new commit 10 years ago

    Added 1 new commit:

    • 2cee7b06 - fix error message
    Added 1 new commit: * 2cee7b06f16 - fix error message
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/vmdriver!6