Skip to content

CIRCLE / cloud

Go to a project
Merge request !47 opened by  

Feature: implement group details

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté @orymate commented
    Owner

    member remove doesn't work fixed

    Edited
  • Őry Máté @orymate commented
    Owner

    group owner can't edit their group; doesn't get owner permission on create fixed

    Edited
  • Őry Máté @orymate commented
    Owner

    no help text or label for mass user add field fixed

    --- a/circle/dashboard/templates/dashboard/group-detail.html
+++ b/circle/dashboard/templates/dashboard/group-detail.html
@@ -48,7 +51,8 @@
         </tr>
   </tbody>
   </table>
-         <textarea name="list-new-namelist" class="form-control"></textarea>
+  <textarea name="list-new-namelist" class="form-control"
+         placeholder="{% trans "List of usernames (one per line)." %}"></textarea>
   <div class="form-actions">
     <button type="submit" class="btn btn-success">{% trans "Save" %}</button>
   </div>
    Edited
  • Bach Dániel @bachdaniel commented
    Owner

    tests? Total: 185 line(s) Missing: 86 line(s) Coverage: 53% fixed

    Edited
  • Oláh István Gergely @ogergo commented
    Developer

    Fixed member removing issue, label, permission problems, tests.

  • Bach Dániel
    @bachdaniel started a discussion on an old version of the diff
    circle/dashboard/static/dashboard/group-details.js
    25 24 });
    26 25 return false;
    27 26 });
    27
    28 /* for Node removes buttons */
    29 $('.delete-from-group').click(function() {
    30 var href = $(this).attr('href');
    31 var tr = $(this).closest('tr');
    32 var group = $(this).data('group_pk');
    33 var member = $(this).data('member_pk');
    34 var dir = window.location.pathname.indexOf('list') == -1;
    35 addModalConfirmation(removeMember,
    36 { 'url': href,
    37 'data': [],
    38 'tr': tr,
    Please register or sign in to reply
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment