Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Open
Merge request !380 opened Jul 15, 2016 by Czémán Arnold@cemiarni 
  • Report abuse
Report abuse

Rework garbage collector logic

New garbage collector do not move disks unsufficient. It marks deleted disks in modely only. Sort disk by creation time from model data instead of filesystem data.

Requires: storagedriver's new_gc branch

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b new_gc origin/new_gc

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff new_gc

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 3
  • Pipelines 2
  • Changes 6
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Czémán Arnold @cemiarni

    mentioned in merge request storagedriver!12

    Jul 15, 2016

    mentioned in merge request storagedriver!12

    mentioned in merge request circle/storagedriver!12
    Toggle commit list
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Jul 18, 2016
    circle/storage/models.py
    75 75 raise WorkerNotFound()
    76 76  
    77 77 def get_deletable_disks(self):
    78 return [disk.filename for disk in
    79 self.disk_set.filter(
    80 destroyed__isnull=False) if disk.is_deletable]
    78 deletables = [disk for disk in self.disk_set.filter(
    79 destroyed__isnull=False) if disk.is_deletable]
    80 deletables = sorted(deletables, key=lambda disk: disk.destroyed)
    • Kálmán Viktor @kviktor commented Jul 18, 2016
      Owner

      order_by

      order_by
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on the diff Jul 18, 2016
    circle/storage/models.py
    75 75 raise WorkerNotFound()
    76 76  
    77 77 def get_deletable_disks(self):
    78 return [disk.filename for disk in
    79 self.disk_set.filter(
    80 destroyed__isnull=False) if disk.is_deletable]
    78 deletables = [disk for disk in self.disk_set.filter(
    79 destroyed__isnull=False) if disk.is_deletable]
    80 deletables = sorted(deletables, key=lambda disk: disk.destroyed)
    81
    82 return [disk.filename for disk in deletables]
    • Kálmán Viktor @kviktor commented Jul 18, 2016
      Owner

      values_list("filename", flat=True)

      values_list("filename", flat=True)
    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 9b04178a - vm, storage, dashboard: rework vm recover and disk restoration
    Jul 22, 2016

    Added 1 commit:

    • 9b04178a - vm, storage, dashboard: rework vm recover and disk restoration
    Added 1 commit: * 9b04178a - vm, storage, dashboard: rework vm recover and disk restoration
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • db8e4554 - vm: remove non-existent disk during recover
    Aug 12, 2016

    Added 1 commit:

    • db8e4554 - vm: remove non-existent disk during recover
    Added 1 commit: * db8e4554 - vm: remove non-existent disk during recover
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!380