Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !145 opened Aug 01, 2014 by Kálmán Viktor@kviktor 
  • Report abuse
Report abuse

If the latest activity has a new resultant state add spining icon to the status

https://miskolc.cloud.bme.hu:18525/dashboard/vm/438/#activity

  • Discussion 3
  • Commits 3
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on commit 32edaf0d Aug 01, 2014
    circle/dashboard/views.py
    310 310 activities = activities[:10]
    311 311 context['activities'] = activities
    312 312 context['show_show_all'] = show_show_all
    313 latest = instance.get_latest_activity_in_progress()
    314 context['is_new_state'] = (latest and
    315 instance.status != latest.resultant_state)
    • Őry Máté @orymate commented Aug 01, 2014
      Owner

      what if resultant_state is None?

      what if resultant_state is None?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on commit 32edaf0d Aug 01, 2014
    circle/vm/models/instance.py
    975 975 return vm_tasks.screenshot.apply_async(args=[self.vm_name],
    976 976 queue=queue_name
    977 977 ).get(timeout=timeout)
    978
    979 def get_latest_activity_in_progress(self):
    980 try:
    981 return InstanceActivity.objects.filter(
    982 instance=self, succeeded=None).latest("started")
    • Őry Máté @orymate commented Aug 01, 2014
      Owner

      we could maybe filter to top-level activities (the ones with no parent)

      or also to those, which have any resultant_state (but that should be a parameter, or the function name is misleading)

      Edited Aug 01, 2014
      we could maybe filter to top-level activities (the ones with no parent) or also to those, which have any resultant_state (but that should be a parameter, or the function name is misleading)
    Please register or sign in to reply
  • Őry Máté @orymate commented Aug 01, 2014
    Owner

    +1

    +1
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Őry Máté
Assignee
Őry Máté @orymate
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!145