Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !139 opened Jul 30, 2014 by Bach Dániel@bachdaniel 
  • Report abuse
Report abuse

readable-name-review

  • Discussion 6
  • Commits 7
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on the diff Jul 29, 2014
    circle/storage/models.py
    320 320  
    321 321 if self.is_ready:
    322 322 return True
    323 if self.base and not self.base.is_ready:
    324 raise Exception("Base image is not ready.")
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      humanize

      humanize
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Jul 29, 2014
    circle/storage/models.py
    440 442 disk = Disk.create(datastore=self.datastore,
    441 443 base=new_base,
    442 444 name=self.name, size=self.size,
    443 type=new_type)
    445 type=new_type, dev_num=self.dev_num)
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      is this related?

      is this related?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Jul 29, 2014
    circle/storage/models.py
    457 459 AbortableAsyncResult(remote.id).abort()
    458 460 disk.destroy()
    459 461 raise Exception("Save as aborted by use.")
    462 disk.is_ready = True
    463 disk.save()
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      is this related?

      is this related?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Jul 29, 2014
    circle/storage/models.py
    320 320  
    321 321 if self.is_ready:
    322 322 return True
    323 if self.base and not self.base.is_ready:
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      if this wasn't saved till now, all the old templates will become useless. could add a datamigration which sets it to true for all existing disks

      Edited Jul 30, 2014
      if this wasn't saved till now, all the old templates will become useless. could add a datamigration which sets it to true for all existing disks
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Jul 29, 2014
    circle/vm/tasks/local_agent_tasks.py
    74 77 instance=instance, activity_code='vm.Instance.agent.cleanup').exists()
    75 78  
    76 with instance_activity(code_suffix='agent', instance=instance) as act:
    77 with act.sub_activity('starting'):
    79 with instance_activity(code_suffix='agent',
    80 readable_name=ugettext_noop('agent'),
    81 instance=instance) as act:
    82 with act.sub_activity('starting',
    83 readable_name=ugettext_noop('starting')):
    78 84 pass
    79 85  
    80 86 if version and version != settings.AGENT_VERSION:
    81 87 try:
    82 with act.sub_activity('update'):
    88 with act.sub_activity('update',
    89 readable_name=ugettext_noop('update')):
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      update agent to %(version)s

      update agent to %(version)s
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Jul 29, 2014
    circle/vm/tasks/local_agent_tasks.py
    91 98 measure_boot_time(instance)
    92 99 send_init_commands(instance, act, vm)
    93 100  
    94 with act.sub_activity('start_access_server'):
    101 with act.sub_activity('start_access_server',
    102 readable_name=ugettext_noop('start acces server')
    • Őry Máté @orymate commented Jul 29, 2014
      Owner

      ss

      ss
    Please register or sign in to reply
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Guba Sándor
Assignee
Guba Sándor @gubasandor
Assign to
IK migration
Milestone
IK migration
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: circle/cloud!139